Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Kinsta deployment documentation #9430

Merged
merged 2 commits into from Oct 20, 2023
Merged

Conversation

palmiak
Copy link
Contributor

@palmiak palmiak commented Oct 20, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

At Kinsta, we just added a new service that will fit Docusarus better than the previously mentioned in the documentation.

Test links

Deploy preview: https://deploy-preview-9430--docusaurus-2.netlify.app/

Related issues/PRs

#8375 - initial PR for adding Kinsta

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 20, 2023
@netlify
Copy link

netlify bot commented Oct 20, 2023

[V2]

Name Link
🔨 Latest commit 0147426
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6532616a76bce9000821b42d
😎 Deploy Preview https://deploy-preview-9430--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 59 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation/ 🟠 73 🟢 98 🟢 92 🟢 100 🟠 89 Report
/docs/category/getting-started/ 🟠 80 🟢 100 🟢 92 🟢 90 🟠 89 Report
/blog/ 🟠 75 🟢 100 🟢 92 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3/ 🟠 66 🟢 97 🟢 92 🟢 100 🟠 89 Report
/blog/tags/release/ 🟠 82 🟢 100 🟢 92 🟠 80 🟠 89 Report
/blog/tags/ 🟠 80 🟢 100 🟢 92 🟢 90 🟠 89 Report

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

website/docs/deployment.mdx Outdated Show resolved Hide resolved
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 20, 2023
@slorber slorber changed the title Updates Kinsta description in documentation docs: update Kinsta deployment documentation Oct 20, 2023
@palmiak
Copy link
Contributor Author

palmiak commented Oct 20, 2023

Thanks.

BTW - one question: why does Kinsta appear only in the canary version, not in the main one?
https://docusaurus.io/docs/deployment - Azure is the last one
https://docusaurus.io/docs/next/deployment - Kinsta is listed at the end

@slorber
Copy link
Collaborator

slorber commented Oct 20, 2023

Thanks.

BTW - one question: why does Kinsta appear only in the canary version, not in the main one? docusaurus.io/docs/deployment - Azure is the last one docusaurus.io/docs/next/deployment - Kinsta is listed at the end

because you didn't backport your changes to older versioned docs

But it doesn't matter because v3.0 is going to be released very soon and it will be on /docs/deployment very soon

@slorber slorber merged commit f674e02 into facebook:main Oct 20, 2023
8 checks passed
@palmiak
Copy link
Contributor Author

palmiak commented Oct 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants