Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): improve dev perf, fine-grained site reloads - part 3 #9975

Merged
merged 7 commits into from Mar 28, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 21, 2024

Motivation

This is a follow-up of the DX improvements from:

The goal of this is to improve the dev experience performance.

This notably improves the little perf logging infrastructure to trace nested async calls so that we easily notice what is slow in our codebase.

CleanShot 2024-03-21 at 19 31 27@2x

It also moves some async/IO calls around to make plugin hot reloading a bit faster.

Test Plan

Unit tests + dogfood

Test links

https://deploy-preview-9975--docusaurus-2.netlify.app/

@slorber slorber added the pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. label Mar 21, 2024
@slorber slorber requested a review from Josh-Cena as a code owner March 21, 2024 18:24
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

[V2]

Name Link
🔨 Latest commit ead5007
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65fc7b488f7f0d0008536d37
😎 Deploy Preview https://deploy-preview-9975--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 56 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 67 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented Mar 21, 2024

Size Change: 0 B

Total Size: 992 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 765 kB
website/build/index.html 37.9 kB

compressed-size-action

Copy link

netlify bot commented Mar 21, 2024

[V2]

Name Link
🔨 Latest commit 4826a4e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/660552d91da7920008ad90bf
😎 Deploy Preview https://deploy-preview-9975--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber merged commit efbe474 into main Mar 28, 2024
31 checks passed
@slorber slorber deleted the slorber/perf-logging-infrastructure branch March 28, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants