-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): improve dev perf, fine-grained site reloads - part1 #9903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: performance
This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
to backport
This PR is planned to be backported to a stable version of Docusaurus
labels
Feb 29, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
…rber/site-reloading
…object identities
slorber
changed the title
refactor(core): improve dev perf, fine-grained site reloads
refactor(core): improve dev perf, fine-grained site reloads - part1
Mar 8, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: performance
This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
to backport
This PR is planned to be backported to a stable version of Docusaurus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding a single character to a Markdown doc leads to a huge amount of useless CPU/IO work.
Even on a Macbook Pro M3 it's significant:
We should optimize and only reload what is necessary.
This is also the opportunity to refactor and clean a bit our mess + instrument code to debug perf issues more easily in the future
Ideally:
deepEqual(previousContent,newContent)
Note: the full optimization is going to happen in multiple PRs, and this one only implements the initial setup + the most simple optimization (still leading to great perf improvements when editing md files)
Test Plan
Unit tests + local + dogfood
The
start.ts
code is quite difficult to test unfortunately 😅 lots of IO/file watchersTest links
https://deploy-preview-9903--docusaurus-2.netlify.app/