This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix handleBeforeInput not working problem when typing in IME #844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
handleBeforeInput, one of Editor's props, doesn't work when typing in IME like Japanese and korean.
Related Issues
The cause of this problem is that
this.props.handleBeforeInput
is used inedit
mode but it is not used incomposite
mode.More specifically,
editOnBeforeInput
(onBeforeInput handler) in/src/handler/edit/editOnBeforeInput.js
usethis.props.handleBeforeInput
, butonBeforeInput
in/src/handler/composition/DraftEditorCompositionHandler.js
doesn't use it.I solved this problem by adding the
edit
mode logic to thecomposite
mode.close #819, #631
Test Plan
handelBeforeInput
to Editor's props of example.handleBeforeInput
working correctly