Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provided versioned binaries #71

Closed
tcoopman opened this issue Nov 20, 2014 · 8 comments
Closed

provided versioned binaries #71

tcoopman opened this issue Nov 20, 2014 · 8 comments

Comments

@tcoopman
Copy link
Contributor

If you provided versioned binaries then flow-bin can take advantage of that and you can provide the wanted version in your package.json (see: flow/flow-bin#1).

@avikchaudhuri
Copy link
Contributor

cc @dsereni

@sindresorhus
Copy link

Would be handy if you provided them using GitHub Releases and following semver: https://help.github.com/articles/distributing-large-binaries/

@tcoopman
Copy link
Contributor Author

tcoopman commented Dec 4, 2014

Any updates about this?

@tcoopman tcoopman mentioned this issue Jan 4, 2015
@despairblue
Copy link

👍

@tcoopman
Copy link
Contributor Author

tcoopman commented Feb 6, 2015

@gabelevi I see that in the last release you provide versioned downloads: https://github.com/facebook/flow/releases/tag/v0.2.0. Will this always be the case? If so, we can close this issue.

@sindresorhus Can you use these in flow-bin?

@gabelevi
Copy link
Contributor

gabelevi commented Feb 6, 2015

Wow, good eye! I forgot to comment here! Yep, we're going to attach binaries to each release moving forward. I can backfill the old releases if you need, just let me know. I also plan to stop checking the binaries into the ghpages branch and just have them link to the correct release, but haven't done that yet.

We're going to try and follow semvar, though tbh I'm a little fuzzy about it <1.0.0 so I've been following @jeffmo's advice. Many of the changes that we make might cause Flow to find errors that it hadn't noticed before, so most of our releases will be treated as breaking.

As for file size, the binaries seem to compress pretty well and GitHub doesn't seem to have a hard line for what is too big for them to host. So until GitHub yells at us we'll probably keep just uploading them to GitHub.

@tcoopman
Copy link
Contributor Author

tcoopman commented Feb 6, 2015

@sindresorhus do you think it's a good idea to backfill the old releases. For me it's just fine if you provide a new version 0.2.0 and update from this point on.

Thanks for solving!

@tcoopman tcoopman closed this as completed Feb 6, 2015
@sindresorhus
Copy link

@tcoopman No.

Fixed on my end: flow/flow-bin#4

sindresorhus added a commit to flow/flow-bin that referenced this issue Feb 8, 2015
jeffmo pushed a commit to jeffmo/flow that referenced this issue Jul 31, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants