-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provided versioned binaries #71
Comments
cc @dsereni |
Would be handy if you provided them using GitHub Releases and following semver: https://help.github.com/articles/distributing-large-binaries/ |
Any updates about this? |
👍 |
@gabelevi I see that in the last release you provide versioned downloads: https://github.com/facebook/flow/releases/tag/v0.2.0. Will this always be the case? If so, we can close this issue. @sindresorhus Can you use these in flow-bin? |
Wow, good eye! I forgot to comment here! Yep, we're going to attach binaries to each release moving forward. I can backfill the old releases if you need, just let me know. I also plan to stop checking the binaries into the ghpages branch and just have them link to the correct release, but haven't done that yet. We're going to try and follow semvar, though tbh I'm a little fuzzy about it <1.0.0 so I've been following @jeffmo's advice. Many of the changes that we make might cause Flow to find errors that it hadn't noticed before, so most of our releases will be treated as breaking. As for file size, the binaries seem to compress pretty well and GitHub doesn't seem to have a hard line for what is too big for them to host. So until GitHub yells at us we'll probably keep just uploading them to GitHub. |
@sindresorhus do you think it's a good idea to backfill the old releases. For me it's just fine if you provide a new version 0.2.0 and update from this point on. Thanks for solving! |
@tcoopman No. Fixed on my end: flow/flow-bin#4 |
More type-related features
If you provided versioned binaries then flow-bin can take advantage of that and you can provide the wanted version in your package.json (see: flow/flow-bin#1).
The text was updated successfully, but these errors were encountered: