Update dom.js: change NodeList to NodeList<HTMLElement> #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with code like this:
because
querySelectorAll
returnsNodeList
ofElement
, notNode
https://developer.mozilla.org/en-US/docs/Web/API/element.I've changed
NodeList
toNodeList<T>
and signatures of some relevant functions:though HTMLElement is no exactly correct (it could be any of derived classes of
Element
such asSVGElement
, for example) I don't know better solution.Also, there is inconsistency with
HTMLCollection
which is collection ofElement
and will produce error with code sample.