Property descriptors #4788
Closed
Property descriptors #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
property-descriptors
branch
from
a6d8e91
to
7f2c4d6
Compare
swansontec
force-pushed
the
property-descriptors
branch
from
7f2c4d6
to
335dac4
Compare
|
Sorry for the churn on this; I made some mistakes in the original commits, which were not in line with the ES spec. |
|
Could you link supporting docs? |
Closed
|
It looks like this was done in #5067, other than |
|
Cool! That's what we needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core type library was using
anyas the type forObject.getOwnPropertyDescriptorand friends. This pull request fixes that by defining a properObject$PropertyDescriptortype, and applying it to all the relevant functions. It also adds the ES2017 'Object.getOwnPropertyDescriptors' method for good measure.This pull request affects a gazillion files, since it changes line numbers in core.js. Sorry about that.