Update core.js types #5067
Closed
Update core.js types #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsavin
force-pushed
the
core-js-types
branch
4 times, most recently
from
f805805
to
17c197d
Compare
…, Proxy and setTimeout/setInterval
apsavin
force-pushed
the
core-js-types
branch
from
17c197d
to
bdfa1ce
Compare
|
@calebmer Sorry for disturbing, but maybe you can help me with this PR. |
|
Yeah, AppVeyor has been a little flakey recently. I'll try and fix it soon. In the meantime, I'll get this PR tested and reviewed! |
There was a problem hiding this comment.
@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Just how annoying are "pings" (reminder comments with no new information — like this one)? On the other hand, I cannot use getters/setters at all right now (without Related PR: #4788 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PropertyDescriptor, update Object, Function, Proxy and setTimeout/setInterval