Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression stats to --sharedmemory-log-level 1 #5070

Closed
wants to merge 1 commit into from

Conversation

gabelevi
Copy link
Contributor

No description provided.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabelevi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@apsavin
Copy link
Contributor

apsavin commented Oct 12, 2017

@gabelevi what's with AppVeyor? It seems that this check isn't stable. AppVeyor build failed on my PR as well.

hhvm-bot pushed a commit to facebook/hhvm that referenced this pull request Oct 27, 2017
Summary:
Some people on the Flow team were curious about our shared memory compression ratio and how it might change. This diff adds those stats to the --sharedmemory-log-level output.

Closes facebook/flow#5070

Reviewed By: andrewjkennedy

Differential Revision: D6022466

Pulled By: gabelevi

fbshipit-source-id: 435c6ade64bca3804b70ca78c92b7ebd0eba03c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants