[dom.js] add ErrorEvent #8336
[dom.js] add ErrorEvent #8336
Conversation
Summary: There is no `ErrorEvent` declaration in dom.js. This diff adds `ErrorEvent`. MDN documentation: https://developer.mozilla.org/en-US/docs/Web/API/ErrorEvent
jamesisaac
added
the
Library definitions
Summary: Add an ErrorEvent test to ensure the ErrorEvent constructs successfully and its properties adhere to expected types.
|
It looks like there are test failures, but that these are due to offset changes in the expected test outputs. I did some searching around but couldn't find the process for updating the expected files, if there is one. Do I just apply the diffs that get generated when I run the tests to the relevant .exp files? Thanks! |
|
@kedromelon I couldn't find the way to update that snapshot, and I just removed old snapshot and copied raw output from the terminal after running the test on dom. |
Summary: Adding the ErrorEvent test changed line numbers in the .exp files. Update those files with the new values.
|
I ended up using |
There was a problem hiding this comment.
@mroch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: There is no
ErrorEventdeclaration in dom.js. This diff addsErrorEvent.MDN documentation: https://developer.mozilla.org/en-US/docs/Web/API/ErrorEvent
whatwg documentation: https://html.spec.whatwg.org/multipage/webappapis.html#the-errorevent-interface
w3.org documentation: https://www.w3.org/TR/html52/webappapis.html#the-errorevent-interface