Rename and conditionalize source for podspec #385
Conversation
This PR did two things. 1. rename to `hermes-engine` since <https://cocoapods.org/pods/Hermes> already exists 2. conditionalize `spec.source` so it can distribute prebuilt binaries as @alloy suggested at #368 (comment)
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@Huxpro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Huxpro has updated the pull request. You must reimport the pull request before landing. |
|
I think the remaining problem is that you need to rename the podspec file. |
|
@Huxpro has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@Huxpro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
test-apple-runtime passed but not apple-runtime
|
@Huxpro has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@Huxpro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Finally! |
Summary: I cherry-picked this PR which: 1. rename everything to `hermes-engine` since <https://cocoapods.org/pods/Hermes> already exists 2. conditionalize `spec.source` so it can distribute prebuilt binaries as alloy suggested at #368 (comment) Noted that the version in the `podspec` had been updated to 0.7.1 correctly. Pull Request resolved: #385 Test Plan: CircleCI doing fine Reviewed By: tmikov Differential Revision: D24206180 Pulled By: Huxpro fbshipit-source-id: ec46350e00099c61a7de8cc9eb99991af72abdb4
This PR did two things.
hermes-enginesince https://cocoapods.org/pods/Hermes already existsspec.sourceso it can distribute prebuilt binaries as @alloy suggested at Optimise the size of iOS artifacts #368 (comment)