Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and conditionalize source for podspec #385

Closed
wants to merge 6 commits into from
Closed

Rename and conditionalize source for podspec #385

wants to merge 6 commits into from

Commits on Oct 8, 2020

  1. Rename and conditionalize source for podspec 

    This PR did two things.

1. rename to `hermes-engine` since <https://cocoapods.org/pods/Hermes> already exists
2. conditionalize `spec.source` so it can distribute prebuilt binaries as @alloy suggested at #368 (comment)
    @Huxpro
    Huxpro committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    58bb339 View commit details
    Browse the repository at this point in the history

  2. fix spelling

    @Huxpro
    Huxpro committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    349766c View commit details
    Browse the repository at this point in the history

  3. fix another spelling

    @Huxpro
    Huxpro committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    fe218c3 View commit details
    Browse the repository at this point in the history

  4. try to fix test-apple-runtime failure

    @Huxpro
    Huxpro committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    6469dae View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. rename to hermes-engine.podspec

    @Huxpro
    Huxpro committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    408735a View commit details
    Browse the repository at this point in the history

  2. rename even more occurences... 

    test-apple-runtime passed but not apple-runtime
    @Huxpro
    Huxpro committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    1d4e7b0 View commit details
    Browse the repository at this point in the history