Skip to content

Commit

Permalink
Remove last use of setRef()
Browse files Browse the repository at this point in the history
Summary: This is hacky but it's the last place using `setRef()` and we need to think up an alternative API for www to replace it. In the meantime I'd like to kill the `(set|append)Ref` functions on the various array classes.

Reviewed By: billf

Differential Revision: D14884601

fbshipit-source-id: 31ebd2358277fd97cac37c5dffe08c78d5f0c81d
  • Loading branch information
paulbiss authored and hhvm-bot committed Apr 17, 2019
1 parent 0568774 commit 2896b26
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion hphp/runtime/vm/event-hook.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,9 @@ static Variant call_intercept_handler(
}
intArgs = par.append(done).toArray();
} else {
intArgs = par.appendRef(done).toArray();
Variant tmp;
tmp.assignRef(done);
intArgs = par.appendWithRef(tmp).toArray();
}

auto ret = Variant::attach(
Expand Down

0 comments on commit 2896b26

Please sign in to comment.