Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiphop only support UTF-8? #544

Closed
huzhiguang opened this issue Aug 9, 2012 · 4 comments
Closed

hiphop only support UTF-8? #544

huzhiguang opened this issue Aug 9, 2012 · 4 comments

Comments

@huzhiguang
Copy link
Contributor

My php application use other encode ,such as GBK,GB2312 and so on,use htmlspecialchars way encode ,hiphop server out mistake ,

e.g.:
my php code use "htmlspecialchars($escape, ENT_QUOTES, 'GB2312');"
and then hiphop out mistake :
HipHop Fatal error: GB2312 is not implemented yet. in app/Query.php on line 32

UTF-8 encode no probleam.
Please author can tell me ,hiphop whether support other encode unsatisfactory.Thanks

@thedjnK
Copy link
Contributor

thedjnK commented Aug 11, 2012

Why not just use UTF8? It supports all characters so you don't need to mess with character sets :S

@huzhiguang
Copy link
Contributor Author

My company's application use a part of GBK or GB2312,so I find this mistake ( GB2312 is not implemented yet. in app/Query.php on line 32),if hiphop not support GBK or GB2312 ,I try to make the development of encoding UTF-8 standard development.

@sgolemon
Copy link
Contributor

Correct, we don't currently support the range of character sets supported by PHP, primarily because UTF-8 offers the broadest possible support for all character sets without the need to specialize.

Since you use GBK/GB2312, you have a couple options.

#1 Help us add support!

#2 Use iconv or icu to transcode inputs to UTF-8 and use the output buffering mechanism to convert back to your native character set on output.

@ptarjan
Copy link
Contributor

ptarjan commented May 13, 2013

We're closing out all bugs older than 2 months. http://www.hiphop-php.com/wp/?p=575

If this is still an issue, please re-open it, and in order of goodness:

  1. Give detailed repro steps
  2. Write a test case in hphp/tests/quick (run it with hphp/tests/run) and send the pull request
  3. Fix it in a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants