Fix CMake files #2246
Merged
Fix CMake files #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues fixed here: 1. CMake treats variables in macros and functions differently, meaning that the unescaped ARGV wasn't actually the arguments to the macro, instead it was just an undefined variable. 2. CMake has a special ARGN variable, in the same vein as ARGV. However, it contains all the arguments *after* the formal arguments, making the existing `list(REMOVE_AT ARGV 0)` pattern pointless. Should fix facebook#2237 cc @sgolemon
This was referenced Mar 31, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues fixed here:
the unescaped ARGV wasn't actually the arguments to the macro, instead it
was just an undefined variable.
contains all the arguments after the formal arguments, making the
existing
list(REMOVE_AT ARGV 0)pattern pointless.Should fix #2237
cc @sgolemon