Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint rule to indicate missing return staement when testing inside promise then or catch block. #4843

Closed
tushardhole opened this issue Nov 6, 2017 · 2 comments

Comments

@tushardhole
Copy link
Contributor

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
It is mentioned in the jest docs to return a promise when you want to test inside its then or catch block. In case, if a developer misses to add a return statement, then that expectation will not get executed and may result in test which is false positive.

What is the expected behavior?
A lint rule

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
jest: 21.2.1
node: 8.0.0
npm: 5.5.1
OS: Sierra (10.12.6)

@rogeliog
Copy link
Contributor

rogeliog commented Nov 9, 2017

@SimenB Given that #4844 (comment) was closed, I guess we should close this issue also and then reopen it in https://github.com/jest-community/eslint-plugin-jest?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants