Coverage in HTML view is broken #9388

adyz · 2020-01-10T10:17:02Z

🐛 Bug Report

To Reproduce

Steps to reproduce the behavior: (same as: https://jestjs.io/docs/en/getting-started)

Create a new folder
Init a new npm project with npm init
Add Jest as a dependency npm install --save-dev jest
Created a src folder with a main.js file and a main.spec.js test file (one containing sum function and the other the tests as in the Jest docs)
Added a test script in package.json.
Run the script with npm test -- --coverage
When opening the coverage/lcov-report/index.html the HTML does not show the coverage report numbers.

GIT repo here: https://github.com/adyz/jest-coverage-bug-no-ts

Expected behavior

The coverage/lcov-report/index.html should show the actual report numbers

Link to repl or repo (highly encouraged)

https://github.com/adyz/jest-coverage-bug-no-ts

envinfo

npx: installed 1 in 1.36s

  System:
    OS: macOS 10.15.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 13.6.0 - /usr/local/bin/node
    Yarn: 1.12.3 - ~/.yarn/bin/yarn
    npm: 6.13.4 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.9.0 => 24.9.0

Let me know if I should send this to the istanbul.js as well or just there. Not sure where to go from here.
I've also noticed that on old projects the report is fine until I remove the node_modules and reinstall.

Thanks a ton!

The text was updated successfully, but these errors were encountered:

SimenB · 2020-01-10T11:22:32Z

This seems like a bug in istanbul somewhere, as the text reporter works correctly.

@coreyfarrell have you seen this before?

Note that it works correctly on Jest master (which is using the new major of istanbul deps)

SimenB · 2020-01-10T11:42:56Z

#9389 (comment)

diff --git i/package-lock.json w/package-lock.json
index 4ae4388..9e5ba91 100644
--- i/package-lock.json
+++ w/package-lock.json
@@ -2186,9 +2186,9 @@
       "dev": true
     },
     "handlebars": {
-      "version": "4.6.0",
-      "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.6.0.tgz",
-      "integrity": "sha512-i1ZUP7Qp2JdkMaFon2a+b0m5geE8Z4ZTLaGkgrObkEd+OkUKyRbRWw4KxuFCoHfdETSY1yf9/574eVoNSiK7pw==",
+      "version": "4.5.3",
+      "resolved": "https://registry.npmjs.org/handlebars/-/handlebars-4.5.3.tgz",
+      "integrity": "sha512-3yPecJoJHK/4c6aZhSvxOyG4vJKDshV36VHp0iVCDVh7o9w2vwi3NSnL2MMPj3YdduqaBcu7cGbggJQM0br9xA==",
       "dev": true,
       "requires": {
         "neo-async": "^2.6.0",
diff --git i/package.json w/package.json
index 901fec3..2971de5 100644
--- i/package.json
+++ w/package.json
@@ -9,6 +9,7 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
+    "handlebars": "~4.5.3",
     "jest": "^24.9.0"
   }
 }

SimenB · 2020-01-10T11:45:53Z

I've quickly opened up handlebars-lang/handlebars.js#1636 upstream linking back to this issue for the reproduction

coreyfarrell · 2020-01-10T15:32:35Z

I've pushed the latest-2.x branch to https://github.com/istanbuljs/istanbuljs with a cherry-pick of the handlebars removal patch.

Publishing this to npm is difficult for me as it's not possible to publish under the npm next tag, istanbul-reports@3.0.0 is already latest so any 2.x backport will automatically be available in production.

I'd appreciate anyone who has the time to manually test my patch. Due to istanbul-reports being in a monorepo it's not possible to have npm install directly from git, the following process must be followed:

git clone https:/github.com/istanbuljs/istanbuljs
git checkout latest-2.x
cd istanbuljs/packages/istanbul-reports
npm pack
add "istanbul-reports": "file:absolute/path/to/istanbul-reports-2.2.5.tgz" to the dependencies of your project
do what is necessary to ensure istanbul-reports from the tarball is the only version installed in your project (npm ls handlebars should not show it being installed by istanbul-reports)
test your project, verify that HTML reports work

I've done this already with the self-tests of nyc@14.1.1 and it seemed to work but I'd like to get some confirmation before I can publish this fix to npm.

adyz · 2020-01-10T15:51:01Z

Hi @coreyfarrell,

I've followed your steps it seems to work well with the repo posted on this issue: https://github.com/adyz/jest-coverage-bug-no-ts

added the generated tgz file (generated following your steps) in package.json"istanbul-reports": "file:../test-istanbul/istanbuljs/packages/istanbul-reports/istanbul-reports-2.2.5.tgz"
removed package-lock.json and node_modules
ran npm install again
ran npm npm test -- --coverage and the HTML looks fine now

Thanks a ton!

adyz · 2020-01-10T16:00:22Z

Actually, I've tried to add my changes on a separate branch on my repo and the HTML it's not working anymore... I'll try again this weekend alt will let you know... sorry for the false positive

coreyfarrell · 2020-01-10T16:01:18Z

Thanks for testing, istanbul-reports gets 6+ million downloads per week so releasing a broken version would bombard me with reports (I suspect many people are not seeing this handlebars bug due to package-lock files). I'm going to give this a little time to hopefully get a couple more testers before I publish (I'm also still fighting with CI for the istanbuljs repo itself).

coreyfarrell · 2020-01-10T16:02:40Z

BTW you'll want to remove package-lock.json, not package.json. I'm guessing that was just a typo here.

adyz · 2020-01-10T16:06:28Z

Yes, typo, sorry. Not sure what is happening with my machine that first time worked and the second time did not. Definitely wait a bit more before release and more tests.

coreyfarrell · 2020-01-10T16:08:28Z

In the case where it fails what does npm ls handlebars show?

adyz · 2020-01-11T09:03:14Z

Sorry for the late response @coreyfarrell

└─┬ jest@24.9.0
  └─┬ jest-cli@24.9.0
    └─┬ @jest/core@24.9.0
      └─┬ @jest/reporters@24.9.0
        └─┬ istanbul-reports@2.2.6
          └── handlebars@4.7.0

Not sure what was the desired version.

I've created a branch here with the changes:
https://github.com/adyz/jest-coverage-bug-no-ts/tree/test/local-istanbul

I hope it helps!

Thank you!

coreyfarrell · 2020-01-11T09:20:07Z

Yes this helps, istanbul-reports@2.x already had a backport that didn't get merged into master and I forgot about, so my patched copy of istanbul-reports@2.2.5 wasn't being used by jest. I've pushed a couple more commits, please git pull, run npm pack again (this should create istanbul-reports-2.2.6.tgz), then update the tarball version in your repository and reinstall. Once this is done npm ls handlebars should not show any result.

adyz · 2020-01-11T09:53:25Z

Wuhu! Works! The HTML is generated 🥳
I'll be able to do more tests on other projects on Monday using this method if you wish.

adyz · 2020-01-11T09:54:29Z

Pushed the changes and the newly generated package here: https://github.com/adyz/jest-coverage-bug-no-ts/tree/test/local-istanbul

SimenB · 2020-01-11T15:54:53Z

Let's keep this open for visibility until a new version of istanbul-reports@2 is published to npm

coreyfarrell · 2020-01-11T17:58:45Z

@adyz thanks for the update. No further testing is needed. I'm planning to release a new version of istanbul-reports@2 soon. Will comment again when that is complete.

coreyfarrell · 2020-01-11T20:31:40Z

istanbul-reports 2.2.7 is now published to npm. Can anyone confirm this fixes the issue as experienced by jest users?

SimenB · 2020-01-12T01:37:05Z

Deleting the existing istanbul-reports from your lockfile and re-running npm or yarn should fix the issue. It works in the project I tested, so I think we're good to go 👍

adyz · 2020-01-13T09:05:01Z

I've posted this bug for a project that now is working perfectly!

I've removed the node_modules folder and the package-lock.json file.

Thank you!
🥳🥳🥳

springfred · 2020-01-15T08:19:37Z

Coverage in HTML view is broken.
npm ls handlebars
└─┬ istanbul@1.1.0-alpha.1
└─┬ istanbul-api@1.3.7
└─┬ istanbul-reports@1.5.1
└── handlebars@4.7.2

coreyfarrell · 2020-01-15T08:35:49Z

@springfred istanbul-reports@1.5.1 is no longer maintained (current version is 3.0.0). The best fix is to upgrade your dependencies so istanbul-reports@2.2.7 or above is used. If this is not an option you will need to pin handlebars in your own package.json to 4.5.3 then perform a fresh npm install.

SimenB · 2020-01-15T09:37:57Z

Jest upgraded to istanbul v2 as part of the Jest v24 release (in #7016, to be exact), so upgrading to v24 should fix your issue (as it'll pull in the fixed version of istanbul-reports@2)

dpdahal · 2020-03-27T17:14:21Z

hello everyone's why not working this code.
{{#each posts}}

{{_id}}
{{title}}
{{status}}
{{description}}

                                    </tr>
                                {{/each}}

Per jestjs/jest#9388 (comment).

github-actions · 2021-05-11T00:06:22Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

adyz added Bug Report Needs Repro Needs Triage labels Jan 10, 2020

kamilmysliwiec mentioned this issue Jan 10, 2020

Lcov Report not showing metrics nestjs/nest#3778

Closed

SimenB closed this as completed Jan 10, 2020

SimenB mentioned this issue Jan 10, 2020

Version 4.6.0 breaks istanbul (code coverage) html reporter handlebars-lang/handlebars.js#1636

Closed

SimenB added Upstream Bug and removed Bug Report Needs Repro Needs Triage labels Jan 10, 2020

SimenB reopened this Jan 11, 2020

SimenB closed this as completed Jan 12, 2020

adyz mentioned this issue Jan 13, 2020

Coverage report not working facebook/create-react-app#7838

Open

SimenB mentioned this issue Jan 19, 2020

Jest coverage report in html missing coverage values #9424

Closed

acoutts mentioned this issue Jan 20, 2020

Coverage reports show correct summary in console and XML file but the HTML table is empty #9433

Closed

nephix mentioned this issue Feb 4, 2020

Fixed handlebar spam messages from code coverage report generation raiden-network/light-client#980

Merged

alexsielicki added a commit to sandialabs/slycat that referenced this issue Apr 1, 2020

Updating package lock to address jest issue 9388. jestjs/jest#9388

eada418

eventualbuddha added a commit to votingworks/bmd that referenced this issue Oct 19, 2020

fix(coverage): update istanbul-reports to fix HTML coverage reports

04730eb

Per jestjs/jest#9388 (comment).

eventualbuddha mentioned this issue Oct 19, 2020

fix(coverage): update istanbul-reports to fix HTML coverage reports votingworks/bmd#1511

Merged

beausmith pushed a commit to votingworks/vxsuite that referenced this issue Nov 2, 2020

fix(coverage): update istanbul-reports to fix HTML coverage reports

1784702

Per jestjs/jest#9388 (comment).

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coverage in HTML view is broken #9388

Coverage in HTML view is broken #9388

adyz commented Jan 10, 2020 •

edited

Loading

SimenB commented Jan 10, 2020 •

edited

Loading

SimenB commented Jan 10, 2020 •

edited

Loading

SimenB commented Jan 10, 2020 •

edited

Loading

coreyfarrell commented Jan 10, 2020

adyz commented Jan 10, 2020 •

edited

Loading

adyz commented Jan 10, 2020

coreyfarrell commented Jan 10, 2020

coreyfarrell commented Jan 10, 2020

adyz commented Jan 10, 2020

coreyfarrell commented Jan 10, 2020

adyz commented Jan 11, 2020 •

edited

Loading

coreyfarrell commented Jan 11, 2020

adyz commented Jan 11, 2020

adyz commented Jan 11, 2020

SimenB commented Jan 11, 2020 •

edited

Loading

coreyfarrell commented Jan 11, 2020

coreyfarrell commented Jan 11, 2020

SimenB commented Jan 12, 2020

adyz commented Jan 13, 2020

springfred commented Jan 15, 2020

coreyfarrell commented Jan 15, 2020

SimenB commented Jan 15, 2020

dpdahal commented Mar 27, 2020

github-actions bot commented May 11, 2021

Coverage in HTML view is broken #9388

Coverage in HTML view is broken #9388

Comments

adyz commented Jan 10, 2020 • edited Loading

🐛 Bug Report

To Reproduce

Expected behavior

Link to repl or repo (highly encouraged)

envinfo

SimenB commented Jan 10, 2020 • edited Loading

SimenB commented Jan 10, 2020 • edited Loading

SimenB commented Jan 10, 2020 • edited Loading

coreyfarrell commented Jan 10, 2020

adyz commented Jan 10, 2020 • edited Loading

adyz commented Jan 10, 2020

coreyfarrell commented Jan 10, 2020

coreyfarrell commented Jan 10, 2020

adyz commented Jan 10, 2020

coreyfarrell commented Jan 10, 2020

adyz commented Jan 11, 2020 • edited Loading

coreyfarrell commented Jan 11, 2020

adyz commented Jan 11, 2020

adyz commented Jan 11, 2020

SimenB commented Jan 11, 2020 • edited Loading

coreyfarrell commented Jan 11, 2020

coreyfarrell commented Jan 11, 2020

SimenB commented Jan 12, 2020

adyz commented Jan 13, 2020

springfred commented Jan 15, 2020

coreyfarrell commented Jan 15, 2020

SimenB commented Jan 15, 2020

dpdahal commented Mar 27, 2020

github-actions bot commented May 11, 2021

adyz commented Jan 10, 2020 •

edited

Loading

SimenB commented Jan 10, 2020 •

edited

Loading

SimenB commented Jan 10, 2020 •

edited

Loading

SimenB commented Jan 10, 2020 •

edited

Loading

adyz commented Jan 10, 2020 •

edited

Loading

adyz commented Jan 11, 2020 •

edited

Loading

SimenB commented Jan 11, 2020 •

edited

Loading