Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): support v12 node typings #10336

Merged
merged 5 commits into from Jul 30, 2020
Merged

fix(worker): support v12 node typings #10336

merged 5 commits into from Jul 30, 2020

Conversation

@SimenB
Copy link
Collaborator

SimenB commented Jul 30, 2020

Summary

People using "older" @types/node will get type errors with the import

Test plan

Installed a version of @types/node that matches our engine requirement. Without the changes here, there's a type error now

SimenB added 2 commits Jul 30, 2020
@@ -17,7 +17,7 @@
"@types/babel__template": "^7.0.0",
"@types/dedent": "0.7.0",
"@types/jest": "24.0.2",
"@types/node": "*",
"@types/node": "~10.14.0",

This comment has been minimized.

@SimenB

SimenB Jul 30, 2020 Author Collaborator

jest/package.json

Lines 129 to 131 in 3bdb8e3

"engines": {
"node": ">= 10.14.2"
}

SimenB added 2 commits Jul 30, 2020
@SimenB SimenB merged commit 2db6aa1 into facebook:master Jul 30, 2020
18 of 22 checks passed
18 of 22 checks passed
cleanup-runs
Details
Running TypeScript compiler & ESLint
Details
Node v10.x on ubuntu-latest
Details
Node v10.x on macOS-latest
Details
Node v10.x on windows-latest
Details
Node v12.x on ubuntu-latest
Details
Node v12.x on macOS-latest
Details
Node v12.x on windows-latest
Details
Node v13.x on ubuntu-latest
Details
Node v13.x on macOS-latest
Details
Node v13.x on windows-latest
Details
Node v14.x on ubuntu-latest
Details
Node v14.x on macOS-latest
Details
Node v14.x on windows-latest
Details
ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-12 CircleCI is running your tests
Details
facebook.jest in progress
Details
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: test-node-13 Your tests passed on CircleCI!
Details
ci/circleci: test-node-14 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
@SimenB SimenB deleted the SimenB:worker-types branch Jul 30, 2020
@G-Rath
Copy link
Contributor

G-Rath commented Jul 31, 2020

Shouldn't the dependencies on @types/node be just >= 10.14.2, because Jest supports higher than Node 10?

I'm not even sure if typescript respects nested node _modules when searching for @types tbh 🤔

@SimenB
Copy link
Collaborator Author

SimenB commented Jul 31, 2020

Shouldn't the dependencies on @types/node be just >= 10.14.2, because Jest supports higher than Node 10?

I want to install the lowest one without manually messing in the lockfile.

I'm not even sure if typescript respects nested node _modules when searching for @types tbh 🤔

It does, otherwise this pr would have failed CI due to the 14 one I added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.