Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade jsdom to 16.4.0 #10578

Merged
merged 1 commit into from
Oct 5, 2020
Merged

chore(deps): upgrade jsdom to 16.4.0 #10578

merged 1 commit into from
Oct 5, 2020

Conversation

bschlenk
Copy link
Contributor

@bschlenk bschlenk commented Oct 4, 2020

Summary

Fixes #10489

Jsdom 16.2.2 causes "Cannot read property 'some' of undefined" error.

Test plan

Ran yarn test and everything passed.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already within semver range, but doesn't hurt to force the newer versions I guess

@SimenB SimenB merged commit 97e683b into jestjs:master Oct 5, 2020
@SimenB
Copy link
Member

SimenB commented Oct 5, 2020

Thanks @bschlenk!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting "Cannot read property 'some' of undefined" when running tests
3 participants