Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use modern fake timers by default #10874

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 26, 2020

Summary

As announced in the v26 blog post

Test plan

Green CI

@thymikee
Copy link
Collaborator

Fake promises test fails, which I think aligns with facebook/react-native#29303, but I didn't go into details, so may be wrong.

@SimenB SimenB added this to the Jest 27 milestone Dec 5, 2020
@SimenB SimenB force-pushed the default-fake-timers branch 2 times, most recently from d03c16a to 6744804 Compare December 5, 2020 15:44
@SimenB
Copy link
Member Author

SimenB commented Dec 5, 2020

@thymikee dunno about that issue, the issue here is the test uses runAllImmediates which doesn't work with modern timers. Just using runAllTimers instead fixes it

@SimenB SimenB merged commit 6c64c19 into jestjs:master Dec 5, 2020
@SimenB SimenB deleted the default-fake-timers branch December 5, 2020 16:10
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants