Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flush animation frames every 16ms when using legacy timers #11567

Merged
merged 5 commits into from Jun 14, 2021

Conversation

@eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Jun 14, 2021

Summary

Closes #11565

Defaulting to 60fps target for animation frames which matches jsdom.

Test plan

  • CI green (failures look unrelated)
@eps1lon eps1lon force-pushed the feat/legacy-fake-timers/raf branch from 5d13bc5 to 26dc18c Jun 14, 2021
SimenB
SimenB approved these changes Jun 14, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

packages/jest-fake-timers/src/legacyFakeTimers.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #11567 (806e5fa) into master (d1882f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11567      +/-   ##
==========================================
+ Coverage   68.94%   68.95%   +0.01%     
==========================================
  Files         312      312              
  Lines       16314    16325      +11     
  Branches     4726     4730       +4     
==========================================
+ Hits        11247    11257      +10     
- Misses       5039     5040       +1     
  Partials       28       28              
Impacted Files Coverage Δ
packages/jest-fake-timers/src/legacyFakeTimers.ts 94.87% <100.00%> (+0.25%) ⬆️
packages/expect/src/utils.ts 95.58% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1882f2...806e5fa. Read the comment docs.

@eps1lon

This comment has been hidden.

@eps1lon eps1lon marked this pull request as ready for review Jun 14, 2021
@SimenB SimenB merged commit aeb1ab5 into facebook:master Jun 14, 2021
28 of 30 checks passed
@eps1lon eps1lon deleted the feat/legacy-fake-timers/raf branch Jun 14, 2021
@SimenB
Copy link
Collaborator

@SimenB SimenB commented Jun 22, 2021

@github-actions
Copy link

@github-actions github-actions bot commented Jul 23, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants