Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy-timers): Do not add setImmediate and clearImmediate if they do not exist in the global environment #11599

merged 1 commit into from Jun 22, 2021


Copy link

@SimenB SimenB commented Jun 22, 2021


Fixes #11539

Test plan


鈥 they do not exist in the global environment
@SimenB SimenB force-pushed the fake-timers-legacy-immediate branch from c79b3e0 to 91c932c Jun 22, 2021
Copy link

@codecov-commenter codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #11599 (91c932c) into master (6826764) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11599   +/-   ##
  Coverage   69.00%   69.01%           
  Files         312      312           
  Lines       16331    16335    +4     
  Branches     4730     4734    +4     
+ Hits        11269    11273    +4     
  Misses       5034     5034           
  Partials       28       28           
Impacted Files Coverage 螖
packages/jest-fake-timers/src/legacyFakeTimers.ts 94.95% <100.00%> (+0.08%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6826764...91c932c. Read the comment docs.

@SimenB SimenB merged commit 6373529 into facebook:master Jun 22, 2021
25 of 30 checks passed
@SimenB SimenB deleted the fake-timers-legacy-immediate branch Jun 22, 2021
Copy link

@github-actions github-actions bot commented Jul 23, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants