Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove is-ci in favor of ci-info #11973

Merged
merged 3 commits into from Oct 18, 2021

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Oct 18, 2021

Summary

Just another tiny improvement. Apparently, to do its job, is-ci is simply calling ci-info.

Using ci-info directly removes one micro library from the dependency tree. This is the only improvement introduced by this PR. (Also @types/is-ci becomes unnecessary.)

I was sure that process.env.CI ? true : false would be enough to detect CI. Was surprised to see a dependency. So it made me curious to look inside.

Test plan

I updated mocks in unit tests. The rest should work.

SimenB
SimenB approved these changes Oct 18, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

works for me 🙂 Thanks!

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #11973 (d0332d0) into main (9d737d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11973   +/-   ##
=======================================
  Coverage   68.74%   68.74%           
=======================================
  Files         323      323           
  Lines       16649    16649           
  Branches     4805     4805           
=======================================
  Hits        11445    11445           
  Misses       5171     5171           
  Partials       33       33           
Impacted Files Coverage Δ
packages/jest-config/src/Defaults.ts 100.00% <ø> (ø)
packages/jest-util/src/isInteractive.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d737d7...d0332d0. Read the comment docs.

@SimenB SimenB merged commit e7edb75 into facebook:main Oct 18, 2021
29 of 30 checks passed
@mrazauskas mrazauskas deleted the chore-remove-is-ci branch Oct 18, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Nov 18, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants