Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: BigInt is always defined, do not conditionally check for it #11979

Merged
merged 2 commits into from Oct 19, 2021

Conversation

SimenB
Copy link
Collaborator

@SimenB SimenB commented Oct 19, 2021

Summary

The global has existed since node 10.4 (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#browser_compatibility), while the lowest version we support is node 10.13. So we don't need to conditionally look for it

Test plan

Green CI

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #11979 (f571576) into main (7092dfb) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11979   +/-   ##
=======================================
  Coverage   68.74%   68.74%           
=======================================
  Files         323      323           
  Lines       16649    16649           
  Branches     4808     4808           
=======================================
+ Hits        11445    11446    +1     
+ Misses       5171     5170    -1     
  Partials       33       33           
Impacted Files Coverage Δ
packages/expect/src/asymmetricMatchers.ts 83.05% <ø> (ø)
packages/expect/src/utils.ts 96.37% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7092dfb...f571576. Read the comment docs.

@SimenB SimenB merged commit 9d286a6 into facebook:main Oct 19, 2021
27 of 30 checks passed
@SimenB SimenB deleted the bigint-always branch Oct 19, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Nov 19, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants