Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-worker] Don't pass explicit env to new Worker when using worker_threads #12141

Merged
merged 3 commits into from Dec 13, 2021

Conversation

nicolo-ribaudo
Copy link
Contributor

@nicolo-ribaudo nicolo-ribaudo commented Dec 11, 2021

Summary

#12128 wasn't enough to fix the regression introduced by #12069: it was still broken when using the NODE_OPTIONS env var because of nodejs/node#41103 (comment).

Test plan

I updated the existing tests, but I would have loved if they were not all mock-based but spawned real workers 馃槄

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Dec 11, 2021

Codecov Report

Merging #12141 (7d8b833) into main (2acf623) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12141   +/-   ##
=======================================
  Coverage   67.71%   67.71%           
=======================================
  Files         328      328           
  Lines       16990    16991    +1     
  Branches     4817     4817           
=======================================
+ Hits        11505    11506    +1     
  Misses       5452     5452           
  Partials       33       33           
Impacted Files Coverage 螖
...kages/jest-worker/src/workers/NodeThreadsWorker.ts 93.54% <酶> (酶)
packages/jest-worker/src/workers/threadChild.ts 91.30% <100.00%> (+0.12%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2acf623...7d8b833. Read the comment docs.

SimenB
SimenB approved these changes Dec 13, 2021
Copy link
Collaborator

@SimenB SimenB left a comment

thanks!

@SimenB SimenB merged commit 7148872 into facebook:main Dec 13, 2021
2 of 10 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the jest-worker-id branch Dec 13, 2021
@SimenB
Copy link
Collaborator

@SimenB SimenB commented Dec 13, 2021

@nicolo-ribaudo
Copy link
Contributor Author

@nicolo-ribaudo nicolo-ribaudo commented Dec 13, 2021

Thanks!

@github-actions
Copy link

@github-actions github-actions bot commented Jan 13, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants