Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with trailing slash in matching coverageThreshold keys #12714

Merged
merged 10 commits into from
Apr 27, 2022
Merged

fix: issue with trailing slash in matching coverageThreshold keys #12714

merged 10 commits into from
Apr 27, 2022

Conversation

wespickett
Copy link
Contributor

#12703

Details in linked issue

Summary

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @wespickett!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

SimenB
SimenB requested changes Apr 23, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

this is failing on windows and prettier is unhappy. could you take a look?

@wespickett
Copy link
Contributor Author

thanks for the PR!

this is failing on windows and prettier is unhappy. could you take a look?

@SimenB addressed the failing tests on Windows and lint issues. Let me know if there's anything else, thanks!

@SimenB SimenB linked an issue Apr 27, 2022 that may be closed by this pull request
[Bug]: Path coverage thresholds include unexpected files with similar paths #12703
Closed
SimenB
SimenB approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 27eb77e into jestjs:main Apr 27, 2022
@jestjs jestjs deleted a comment from 337Gslime Apr 27, 2022
F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
@wespickett @F3n67u
fix: issue with trailing slash in matching coverageThreshold keys (je…
2f27060 
…stjs#12714)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Path coverage thresholds include unexpected files with similar paths
3 participants
@wespickett @facebook-github-bot @SimenB