Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jest/transform): throw better error if an invalid return value if encountered #12764

merged 4 commits into from Apr 28, 2022


Copy link

From #12750 (comment)


As it was mentioned in the comment: if a transformer returns an invalid value, it would be good to include transformer’s path in the error message. Link to Upgrade Guide is also a useful detail.

Test plan

Green CI.

SimenB approved these changes Apr 28, 2022
Copy link

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff 👍

@mrazauskas mrazauskas requested a review from SimenB April 28, 2022 07:49
@mrazauskas mrazauskas force-pushed the fix-better-InvalidReturnValueError branch from 52bacd2 to cf82664 Compare April 28, 2022 07:53
@SimenB SimenB merged commit 880e04c into facebook:main Apr 28, 2022
89 checks passed
@mrazauskas mrazauskas deleted the fix-better-InvalidReturnValueError branch April 28, 2022 08:32
F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants