Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair caching of typescript compiler instances #13099

merged 2 commits into from Aug 7, 2022


Copy link

@zebreus zebreus commented Aug 7, 2022


After updating to jest 28, testing crashes when loading multiple TypeScript jest config files (e.g. jest --projects jest-node.config.ts jest-jsdom.config.ts). This only appears to happen, if the files import something. The issue has been documented previously in kulshekhar/ts-jest#3691.

The cause was a race condition when creating the typescript compiler service, leading to ts-node being registered multiple times. This causes a crash similar to TypeStrong/ts-node#883.

Test plan

I added integration tests based on the multiProjectRunner test. They verify that:

  • a single TypeScript jest config with imports works as expected
  • multiple TypeScript jest configs without imports work as expected
  • multiple TypeScript jest configs with imports work as expected

The first and the second test would have already passed previously, the third failed previously.

Copy link

Hi @zebreus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.


In order for us to review and merge your suggested changes, please sign at If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at Thanks!

SimenB approved these changes Aug 7, 2022
Copy link

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks! could you make sure to sign the CLA as well? 🙂

Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB SimenB merged commit 0b679b8 into facebook:main Aug 7, 2022
27 of 32 checks passed
Copy link

SimenB commented Aug 8, 2022

Copy link

SimenB commented Aug 25, 2022

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants