-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to micromatch v4 #8852
Conversation
FYI we bump into micromatch/micromatch#177 with negated matches. |
Bah, that sucks. Thanks for digging into it 😀 |
I'm working on a PR. As a workaround, we can use |
After some investigation and looking at the |
Ah, ok! That seems fair enough |
Codecov Report
@@ Coverage Diff @@
## next #8852 +/- ##
======================================
Coverage ? 63.8%
======================================
Files ? 274
Lines ? 11576
Branches ? 2841
======================================
Hits ? 7386
Misses ? 3560
Partials ? 630
Continue to review full report at Codecov.
|
* chore: upgrade to micromatch v4 * fix anymatch namespace issue * use match instead of some * add explicit check for length 0 * more length boolean checks
* chore: upgrade to micromatch v4 * fix anymatch namespace issue * use match instead of some * add explicit check for length 0 * more length boolean checks
* chore: upgrade to micromatch v4 * fix anymatch namespace issue * use match instead of some * add explicit check for length 0 * more length boolean checks
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Hopefully this fixes some of out performance issues.
Test plan
Green CI