Deprecate Collection#size(), add Collection#length #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
<3 Any thoughts @fkling? |
vjeux
reviewed
Sep 18, 2016
| @@ -110,6 +110,16 @@ class Collection { | |||
| * @return {number} | |||
| */ | |||
| size() { | |||
| process.stderr.write('Collection#size() is deprecated. Use Collection#length instead'); | |||
There was a problem hiding this comment.
I don't see much harm supporting both. I would just add the other one and not deprecate this one.
|
👍 I also think there is no need to add a deprecation warning. Rest looks good to me 😄 |
DrewML
force-pushed
the
collection-length
branch
from
3b6b71f
to
6978d9d
Compare
|
Removed deprecation. @fkling how do you want me to handle tests for |
|
I'm actually OK with as it is. No need to add tests back. |
euphocat
pushed a commit
to euphocat/jscodeshift
that referenced
this pull request
Oct 22, 2017
**what is the change?:** `npm` -> `yarn` **why make this change?:** I personally find it confusing to have 'npm' in the docs when I'm trying to use 'yarn' consistently. **test plan:** Visual inspection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #150 (assuming it is wanted).
I was going to use
util.deprecate, but cannot do that without using the class fields proposal, so I'm just writing a warning tostderratm.EditorConfigsetup in Atom killed some extra whitespace. Happy to revert if requested.