Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: add test coverage for the internal reconciler #150

Closed
trueadm opened this issue Mar 2, 2021 · 1 comment
Closed

Request: add test coverage for the internal reconciler #150

trueadm opened this issue Mar 2, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@trueadm
Copy link
Collaborator

trueadm commented Mar 2, 2021

We should add Jest tests for how the reconciler handles various node operations (move, delete, insert, etc). We currently have no tests to cover this.
@trueadm trueadm added the good first issue Good for newcomers label Mar 2, 2021
@trueadm trueadm changed the title Request: add tests for the internal reconciler Request: add test coverage for the internal reconciler Mar 2, 2021
@trueadm
Copy link
Collaborator Author

trueadm commented Jun 22, 2021

On reflection, I don't think having tests for the reconciler is a good thing. The reconciler will likely change in the future and adding tests around its implementation details will make things brittle.

@trueadm trueadm closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trueadm