Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap snapshots in node say "Math.random()" in the filename #26

Closed
banga opened this issue Sep 17, 2022 · 1 comment
Closed

Heap snapshots in node say "Math.random()" in the filename #26

banga opened this issue Sep 17, 2022 · 1 comment

Comments

@banga
Copy link

banga commented Sep 17, 2022

I think this line here needs to use a template string: https://github.com/facebookincubator/memlab/blob/eb9a346b30511db932780cd30878379a90abfa48/packages/core/src/lib/NodeHeap.ts#L85

@JacksonGL
Copy link
Member

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants