Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My open source builds are broken #1262

Closed
mdcallag opened this issue Jan 20, 2023 · 3 comments
Closed

My open source builds are broken #1262

mdcallag opened this issue Jan 20, 2023 · 3 comments

Comments

@mdcallag
Copy link
Contributor

The problem commit is here -- "MyRocks to support both dynamic and static plugins".

The cmake command line is here. I have been using this command line for years. It doesn't set -DMYSQL_DYNAMIC_PLUGIN. It fails here. I will try -DWITH_UNIT_TESTS=OFF.

This fails on Ubuntu 22.04 with gcc.

Before compiling I apply this patch although I might only need the diff for get_rocksdb_files.sh from that patch.

@mdcallag
Copy link
Contributor Author

Workaround is to add -DWITH_UNIT_TESTS=OFF to cmake command line.

Will try one more thing.

@mdcallag
Copy link
Contributor Author

A suggestion from @yoshinorim also works and doesn't require me to add -DWITH_UNIT_TESTS

Add this line to storage/rocksdb/CMakeLists.txt
->   ../../sql/partitioning/partition_base.cc
   nosql_access.cc nosql_access.h
   sql_dd.cc sql_dd.h
   ${ROCKSDB_LIB_SOURCES}

facebook-github-bot pushed a commit that referenced this issue Jan 26, 2023
Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue #1262).
This diff fixes it.

squash with: D41313174

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc
@yoshinorim
Copy link
Contributor

Fixed by c75bf30

alanliang pushed a commit to alanliang/mysql-5.6 that referenced this issue Mar 4, 2023
Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

squash with: D41313174

Test Plan: sandcastle verify-mysql-oss-build-with-gcc6 passed

Reviewers: herman, mung

Reviewed By: mung

Subscribers: webscalesql-eng@fb.com

Differential Revision: https://phabricator.intern.facebook.com/D42646920
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 15, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 16, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 17, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 18, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue May 26, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 1, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 14, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 19, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
inikep pushed a commit to inikep/mysql-5.6 that referenced this issue Jun 23, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174

fbshipit-source-id: 8a8708b

---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920

fbshipit-source-id: 16e77bc

---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861

fbshipit-source-id: 65286a7

---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee

fbshipit-source-id: 7520d90
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this issue Oct 3, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174



---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920



---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861



---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this issue Oct 18, 2023
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.

This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.

Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).

This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.

Ways to link
with other libraries such as jemalloc are adjusted accordingly.

Reviewed By: lth

Differential Revision: D41313174



---------------------------------------------------------------

Fix static MyRocks library linkage error with gcc

Summary:
Commit 8a8708b
(MyRocks to support both dynamic and static plugins) caused
compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262).
This diff fixes it.

Reviewed By: lth

Differential Revision: D42646920



---------------------------------------------------------------

Fix MTR test: log_error.test

Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note   MY-011071       Server` entry in the performance_schema.error_log table. Add  MY-011071 to the exclusion list to not change the output.

Reviewed By: yoshinorim

Differential Revision: D42594861



---------------------------------------------------------------

Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261)

Summary:
This fixes the macOS build, where std::uint64_t is unsigned long long.

Pull Request resolved: facebook#1261

Reviewed By: sunshine-Chun

Differential Revision: D42850107

Pulled By: hermanlee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants