Use PRIu64 instead of %lu to format std::uint64_t values #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the macOS build, where std::uint64_t is unsigned long long.
|
@hermanlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
alanliang
pushed a commit
to alanliang/mysql-5.6
that referenced
this pull request
Mar 4, 2023
Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: luqun, jupyung, mung, yoshinori, chni Reviewed By: chni Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D42850107 Tags: accept2ship
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
May 9, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
May 10, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 18, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 26, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 19, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 23, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 fbshipit-source-id: 8a8708b --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 fbshipit-source-id: 16e77bc --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 fbshipit-source-id: 65286a7 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jun 27, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jun 29, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 18, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 19, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 24, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 25, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 26, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jul 27, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Aug 1, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Aug 14, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Aug 24, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to percona/percona-server
that referenced
this pull request
Sep 15, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Oct 16, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Oct 25, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Oct 26, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Oct 26, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Nov 1, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Nov 10, 2023
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 17, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 17, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 18, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 21, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 26, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 30, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 18, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 29, 2024
Upstream commit ID: facebook/mysql-5.6@65f8d20 PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook/mysql-5.6#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee fbshipit-source-id: 7520d90efc4369e203d0c4ee6f52ab02863ca10d
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 2, 2024
Summary: Prior to this diff, fb-mysql MyRocks only supported static plugins, and used sql_print_* APIs for logging, which was not available on dynamic plugins. This diff allows to create either static or dynamic plugins, depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that, adding another option to skip building MyRocks by -DWITHOUT_ROCKSDB_STORAGE_ENGINE. Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin, basically the same behavior as before. With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so). This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed. Ways to link with other libraries such as jemalloc are adjusted accordingly. Reviewed By: lth Differential Revision: D41313174 --------------------------------------------------------------- Fix static MyRocks library linkage error with gcc Summary: Commit 8a8708b (MyRocks to support both dynamic and static plugins) caused compiler error on Ubuntu 22.04 with gcc (Issue facebook#1262). This diff fixes it. Reviewed By: lth Differential Revision: D42646920 --------------------------------------------------------------- Fix MTR test: log_error.test Summary: Diff D41313174 change logging API to LogPluginErrMsg, which introduces a bunch of `Note MY-011071 Server` entry in the performance_schema.error_log table. Add MY-011071 to the exclusion list to not change the output. Reviewed By: yoshinorim Differential Revision: D42594861 --------------------------------------------------------------- Use PRIu64 instead of %lu to format std::uint64_t values (facebook#1261) Summary: This fixes the macOS build, where std::uint64_t is unsigned long long. Pull Request resolved: facebook#1261 Reviewed By: sunshine-Chun Differential Revision: D42850107 Pulled By: hermanlee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the macOS build, where std::uint64_t is unsigned long long.