Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MyRocks DD commits always durable #1403

Closed
wants to merge 1 commit into from
Closed

Make MyRocks DD commits always durable #1403

wants to merge 1 commit into from

Commits on Dec 15, 2023

  1. Make MyRocks DD commits always durable 

    Regular commit durability is governed by the binlog group commit algorithm and
system variables. Make any commits (and prepares in 2PC) involving DD tables
always durable unconditionally, just like InnoDB does. It is implemented through
a new flag Rdb_transaction::m_dd_transaction, which is set in
ha_rocksdb::external_lock and checked in rocksdb_prepare. To avoid confusion,
rename the existing m_ddl_transaction flag to m_bulk_index_transaction. At the
same time tweak ha_rocksdb::is_dd_update to downgrade the DD/system engine check
to an assert.
    @laurynas-biveinis
    laurynas-biveinis committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0f14207 View commit details
    Browse the repository at this point in the history