gcc-7 -Wint-in-bool-contex fix for rdb_datadic.cc #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
|
@gunnarku has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
thanks @gunnarku |
IslamAbdelRahman
pushed a commit
to IslamAbdelRahman/mysql-5.6
that referenced
this pull request
May 31, 2017
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook#598
Github Author: Daniel Black <danielgb@au.ibm.com>
Github PR Sync: {sync, type="child", parent="github", parentrepo="facebook/mysql-5.6", parentprnum="598", parentprfbid="1332720093462018"}
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Reviewers: svcscm
Reviewed By: svcscm
Subscribers: svcscm, webscalesql-eng@fb.com
Differential Revision: https://phabricator.intern.facebook.com/D4908735
Signature: t1:4908735:1492555342:d5c6ad91dcf7b372a3704778fd843e60e07f5505
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 11, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 11, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 11, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 11, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 11, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 15, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Aug 17, 2017
Upstream commit ID : fb-mysql-5.6.35/8f44a9d8bd14674ae85de206b54073bf4587e248
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook/mysql-5.6#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: 4ec220a
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 23, 2019
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes #598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: dc20a04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 12, 2020
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: dc20a04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: dc20a04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: dc20a04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: dc20a04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes facebook#598
Differential Revision: D4908735
Pulled By: gunnarku
fbshipit-source-id: dc20a04
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2021
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes #598
Differential Revision: D4908735 (469992d)
Pulled By: gunnarku
fbshipit-source-id: 06ba72c79a0
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 (facebook@469992d) Pulled By: gunnarku fbshipit-source-id: 06ba72c79a0
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 (facebook@469992d) Pulled By: gunnarku fbshipit-source-id: 06ba72c79a0
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 (facebook@469992d) Pulled By: gunnarku fbshipit-source-id: 06ba72c79a0
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 (facebook@469992d) Pulled By: gunnarku fbshipit-source-id: 06ba72c79a0
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 (facebook@469992d) Pulled By: gunnarku fbshipit-source-id: 06ba72c79a0
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 (facebook@469992d) Pulled By: gunnarku fbshipit-source-id: 06ba72c79a0
hermanlee
pushed a commit
that referenced
this pull request
Jan 10, 2022
Summary:
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Closes #598
Differential Revision: D4908735
Pulled By: gunnarku
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…ona#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook/mysql-5.6#598 Differential Revision: D4908735 Pulled By: gunnarku
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 20, 2022
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 23, 2022
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
laurynas-biveinis
pushed a commit
to laurynas-biveinis/mysql-5.6
that referenced
this pull request
Aug 11, 2022
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
…ebook#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook#598 Differential Revision: D4908735 Pulled By: gunnarku
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…ona#598) Summary: The warning (observed in MariaDB rocksDB at an identical line was:) warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ Closes facebook/mysql-5.6#598 Differential Revision: D4908735 Pulled By: gunnarku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning (observed in MariaDB rocksDB at an identical line was:)
warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
if (real_val_size % Rdb_key_def::PACKED_SIZE * 2) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~