Skip to content

Commit

Permalink
Make run-ios --device example copy-pastable
Browse files Browse the repository at this point in the history
Summary:
This changes the single quotes to double quotes so this command can be copy-pasted.

If a user copy pastes the run-on-device example in bash they will be presented with a confusing prompt because bash expects another terminating single quote.

```
~ben (master *) ~/code/transit: react-native run-ios --device 'Max's iPhone'
>
>
```

It seems minor but this could be just confusing enough to frustrate a beginner or someone not familiar with bash.

This can be tested by running:

```
react-native run-ios --help
```

and verifying that the "run on device" example is changed:

```diff
- react-native run-ios --device 'Max's iPhone'
+ react-native run-ios --device "Max's iPhone"
```
Closes #13145

Differential Revision: D4776305

Pulled By: hramos

fbshipit-source-id: 9500551bfc106cd1687468f7ecc4c91089e1f703
  • Loading branch information
bhelx authored and facebook-github-bot committed Mar 29, 2017
1 parent 56a4538 commit 140c5f6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion local-cli/runIOS/runIOS.js
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ module.exports = {
},
{
desc: "Run on a connected device, e.g. Max's iPhone",
cmd: "react-native run-ios --device 'Max's iPhone'",
cmd: 'react-native run-ios --device "Max\'s iPhone"',
},
],
options: [{
Expand Down

0 comments on commit 140c5f6

Please sign in to comment.