Skip to content
Permalink
Browse files

Remove iOS platform check for running devtools

Summary:
Currently, DevTools only work under ios (although this is undocumented!), because the JavaScriptEngine initialization process skips setupDevTools() on android.

DevTools work fine with Android, as tested on 0.26, 0.27, and 0.28 using Nuclide's inspector.

For reference, [the relevant issue on react-devtools](facebook/react-devtools#229).
Closes #8095

Reviewed By: bestander

Differential Revision: D3430206

Pulled By: javache

fbshipit-source-id: 826f0252fff3f0ec2c843149540a0109e34d1d18
  • Loading branch information
kageurufu authored and Facebook Github Bot 5 committed Jun 15, 2016
1 parent 58881fc commit 1b40db7ec0acb3a38a2a1c73623dbce420d2c1e5
@@ -213,7 +213,7 @@ function setUpMapAndSet() {
function setUpDevTools() {
if (__DEV__) {
// not when debugging in chrome
if (!window.document && require('Platform').OS === 'ios') {
if (!window.document) {
const setupDevtools = require('setupDevtools');
setupDevtools();
}

0 comments on commit 1b40db7

Please sign in to comment.
You can’t perform that action at this time.