Skip to content

Commit

Permalink
Cleanup Buck usages from New App Template (#34881)
Browse files Browse the repository at this point in the history
Summary:
I'm cleaning up the Buck setup in the New App template. It hasn't been touched since 2018 and is currently not working, but will end up being propagated in user space.
This is also affecting the Gradle setup as there is a need to have an extra task just for Buck.

I doubt anyone is using this at this stage. We can get back to it or have a dedicated guide for users that are willing to use it.

## Changelog

[Android] [Remove] - Cleanup Buck usages from New App Template

Pull Request resolved: #34881

Test Plan: Testing was missing on this API so there is nothing to test here

Reviewed By: cipolleschi

Differential Revision: D40142064

Pulled By: cortinico

fbshipit-source-id: 6c65e1030bf3fe1603bfb7d486f8f3fd7d254126
  • Loading branch information
cortinico authored and facebook-github-bot committed Oct 12, 2022
1 parent 305f7c3 commit 32fc551
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 71 deletions.
3 changes: 0 additions & 3 deletions template/_flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
; We fork some components by platform
.*/*[.]android.js

; Ignore "BUCK" generated dirs
<PROJECT_ROOT>/\.buckd/

; Ignore polyfills
node_modules/react-native/Libraries/polyfills/.*

Expand Down
8 changes: 2 additions & 6 deletions template/_gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,15 @@ local.properties
*.iml
*.hprof
.cxx/
*.keystore
!debug.keystore

# node.js
#
node_modules/
npm-debug.log
yarn-error.log

# BUCK
buck-out/
\.buckd/
*.keystore
!debug.keystore

# fastlane
#
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
Expand Down
55 changes: 0 additions & 55 deletions template/android/app/_BUCK

This file was deleted.

7 changes: 0 additions & 7 deletions template/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,6 @@ if (isNewArchitectureEnabled()) {
}
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
from configurations.implementation
into 'libs'
}

apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)

def isNewArchitectureEnabled() {
Expand Down

0 comments on commit 32fc551

Please sign in to comment.