Cleanup Buck usages from New App Template#34881
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 36c9716 |
Collaborator
|
This pull request was successfully merged by @cortinico in 32fc551. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: I'm cleaning up the Buck setup in the New App template. It hasn't been touched since 2018 and is currently not working, but will end up being propagated in user space. This is also affecting the Gradle setup as there is a need to have an extra task just for Buck. I doubt anyone is using this at this stage. We can get back to it or have a dedicated guide for users that are willing to use it. ## Changelog [Android] [Remove] - Cleanup Buck usages from New App Template Pull Request resolved: facebook#34881 Test Plan: Testing was missing on this API so there is nothing to test here Reviewed By: cipolleschi Differential Revision: D40142064 Pulled By: cortinico fbshipit-source-id: 6c65e1030bf3fe1603bfb7d486f8f3fd7d254126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm cleaning up the Buck setup in the New App template. It hasn't been touched since 2018 and is currently not working, but will end up being propagated in user space.
This is also affecting the Gradle setup as there is a need to have an extra task just for Buck.
I doubt anyone is using this at this stage. We can get back to it or have a dedicated guide for users that are willing to use it.
Changelog
[Android] [Removed] - Cleanup Buck usages from New App Template
Test Plan
Testing was missing on this API so there is nothing to test here