packager: GlobalTransformCache: reduce asynchronicity for non-cached …

…bundles Reviewed By: davidaurelio Differential Revision: D4745595 fbshipit-source-id: 3126fdcc11dd1c8085316457ead0cabae633d0db
facebook · Mar 21, 2017 · 439cb76 · 439cb76
1 parent 4cbb645
commit 439cb76
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packager/src/lib/GlobalTransformCache.js b/packager/src/lib/GlobalTransformCache.js
@@ -247,14 +247,15 @@ class GlobalTransformCache {
     });
   }
 
+  shouldFetch(props: FetchProps): boolean {
+    return this._profileSet.has(props.transformOptions);
+  }
+
   /**
    * This may return `null` if either the cache doesn't have a value for that
    * key yet, or an error happened, processed separately.
    */
   async fetch(props: FetchProps): Promise<?CachedResult> {
-    if (!this._profileSet.has(props.transformOptions)) {
-      return null;
-    }
     const uri = await this._fetcher.fetch(GlobalTransformCache.keyOf(props));
     if (uri == null) {
       return null;

diff --git a/packager/src/node-haste/Module.js b/packager/src/node-haste/Module.js
@@ -303,7 +303,7 @@ class Module {
     callback: (error: ?Error, result: ?TransformedCode) => void,
   ) {
     const {_globalCache} = this;
-    if (_globalCache == null) {
+    if (_globalCache == null || !_globalCache.shouldFetch(cacheProps)) {
       this._transformCodeForCallback(cacheProps, callback);
       return;
     }