packager: make legocastle script to write to the global cache

Reviewed By: davidaurelio Differential Revision: D4251001 fbshipit-source-id: bde1e50c82c2cb8f2c2577139061498c809aa37e
facebook · Dec 12, 2016 · 46f8eb0 · 46f8eb0
1 parent d414fdc
commit 46f8eb0
Show file tree

Hide file tree

Showing 2 changed files with 83 additions and 5 deletions.
diff --git a/packager/react-packager/src/lib/GlobalTransformCache.js b/packager/react-packager/src/lib/GlobalTransformCache.js
@@ -26,6 +26,11 @@ type FetchResultURIs = (
   callback: (error?: Error, results?: Map<string, string>) => void,
 ) => mixed;
 
+type StoreResults = (
+  resultsByKey: Map<string, CachedResult>,
+  callback: (error?: Error) => void,
+) => mixed;
+
 type FetchProps = {
   filePath: string,
   sourceCode: string,
@@ -158,6 +163,38 @@ class KeyURIFetcher {
 
 }
 
+class KeyResultStore {
+
+  _storeResults: StoreResults;
+  _batchProcessor: BatchProcessor<{key: string, result: CachedResult}, void>;
+
+  _processResults(
+    keyResults: Array<{key: string, result: CachedResult}>,
+    callback: (error?: Error) => mixed,
+  ) {
+    const resultsByKey = new Map(
+      keyResults.map(pair => [pair.key, pair.result]),
+    );
+    this._storeResults(resultsByKey, error => {
+      callback(error);
+    });
+  }
+
+  store(key: string, result: CachedResult) {
+    this._batchProcessor.queue({key, result}, () => {});
+  }
+
+  constructor(storeResults: StoreResults) {
+    this._storeResults = storeResults;
+    this._batchProcessor = new BatchProcessor({
+      maximumDelayMs: 1000,
+      maximumItems: 100,
+      concurrency: 10,
+    }, this._processResults.bind(this));
+  }
+
+}
+
 function validateCachedResult(cachedResult: mixed): ?CachedResult {
   if (
     cachedResult != null &&
@@ -204,10 +241,17 @@ function globalizeTransformOptions(
 class GlobalTransformCache {
 
   _fetcher: KeyURIFetcher;
+  _store: ?KeyResultStore;
   static _global: ?GlobalTransformCache;
 
-  constructor(fetchResultURIs: FetchResultURIs) {
+  constructor(
+    fetchResultURIs: FetchResultURIs,
+    storeResults?: StoreResults,
+  ) {
     this._fetcher = new KeyURIFetcher(fetchResultURIs);
+    if (storeResults != null) {
+      this._store = new KeyResultStore(storeResults);
+    }
   }
 
   /**
@@ -263,6 +307,12 @@ class GlobalTransformCache {
     });
   }
 
+  store(props: FetchProps, result: CachedResult) {
+    if (this._store != null) {
+      this._store.store(GlobalTransformCache.keyOf(props), result);
+    }
+  }
+
   /**
    * For using the global cache one needs to have some kind of central key-value
    * store that gets prefilled using keyOf() and the transformed results. The
@@ -271,8 +321,14 @@ class GlobalTransformCache {
    * of returning the content directly allows for independent fetching of each
    * result.
    */
-  static configure(fetchResultURIs: FetchResultURIs) {
-    GlobalTransformCache._global = new GlobalTransformCache(fetchResultURIs);
+  static configure(
+    fetchResultURIs: FetchResultURIs,
+    storeResults?: StoreResults,
+  ) {
+    GlobalTransformCache._global = new GlobalTransformCache(
+      fetchResultURIs,
+      storeResults,
+    );
   }
 
   static get() {

diff --git a/packager/react-packager/src/node-haste/Module.js b/packager/react-packager/src/node-haste/Module.js
@@ -230,6 +230,28 @@ class Module {
     );
   }
 
+  _transformAndStoreCodeGlobally(
+    cacheProps: ReadTransformProps,
+    globalCache: GlobalTransformCache,
+    callback: (error: ?Error, result: ?TransformedCode) => void,
+  ) {
+    this._transformCodeForCallback(
+      cacheProps,
+      (transformError, transformResult) => {
+        if (transformError != null) {
+          callback(transformError);
+          return;
+        }
+        invariant(
+          transformResult != null,
+          'Inconsistent state: there is no error, but no results either.',
+        );
+        globalCache.store(cacheProps, transformResult);
+        callback(undefined, transformResult);
+      },
+    );
+  }
+
   _getTransformedCode(
     cacheProps: ReadTransformProps,
     callback: (error: ?Error, result: ?TransformedCode) => void,
@@ -253,8 +275,8 @@ class Module {
           ));
         }
       }
-      if (globalCacheError != null || globalCachedResult == null) {
-        this._transformCodeForCallback(cacheProps, callback);
+      if (globalCachedResult == null) {
+        this._transformAndStoreCodeGlobally(cacheProps, globalCache, callback);
         return;
       }
       callback(undefined, globalCachedResult);