Skip to content

Commit

Permalink
Improve loading error handling on Android WebView
Browse files Browse the repository at this point in the history
Summary:
Loading invalid urls will happen in normal use so this line should be console.warn instead.
Actually ios WebView uses console.warn for this.
See #2904.
Closes #9623

Differential Revision: D3815167

Pulled By: spicyj

fbshipit-source-id: 0badb811b79d89d54c70b41692c609da0a3ef169
  • Loading branch information
Nobuhito Kurose authored and Facebook Github Bot 9 committed Sep 3, 2016
1 parent 367c712 commit 5ba40fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Libraries/Components/WebView/WebView.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ class WebView extends React.Component {
var {onError, onLoadEnd} = this.props;
onError && onError(event);
onLoadEnd && onLoadEnd(event);
console.error('Encountered an error loading page', event.nativeEvent);
console.warn('Encountered an error loading page', event.nativeEvent);

this.setState({
lastErrorEvent: event.nativeEvent,
Expand Down

0 comments on commit 5ba40fe

Please sign in to comment.