Skip to content

Commit

Permalink
fix(virtualized-lists): react-test-renderer is not a runtime depend…
Browse files Browse the repository at this point in the history
…ency (#37955)

Summary:
Installing `react-native` 0.72.x causes a warning about `react-test-renderer` because `react-native/virtualized-lists` has declared a peer dependency on it. As far as I know, it is not used for anything but tests.

```
➤ YN0002: │ react-native@npm:0.72.0-rc.6 [292eb] doesn't provide react-test-renderer (p5a2fb), requested by react-native/virtualized-lists
```

Note that while many package managers default to warnings in this case, there are still a number of users out there for which this is an error.

## Changelog:

[GENERAL] [FIXED] - `react-native/virtualized-lists` does not need `react-test-renderer` at runtime

Pull Request resolved: #37955

Test Plan: n/a

Reviewed By: rshest

Differential Revision: D46871536

Pulled By: NickGerleman

fbshipit-source-id: 1e5e15608ab394bc43cd4e6ac727a74734874642
  • Loading branch information
tido64 authored and facebook-github-bot committed Jun 21, 2023
1 parent b3bb553 commit 7a2a327
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/virtualized-lists/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"react-test-renderer": "18.2.0"
},
"peerDependencies": {
"react-native": "*",
"react-test-renderer": "18.2.0"
"react-native": "*"
}
}

0 comments on commit 7a2a327

Please sign in to comment.