Skip to content

Commit

Permalink
fix: remove the unused packages and convert minimist to yargs (#23467)
Browse files Browse the repository at this point in the history
Summary:
`Minimist` package functionality can be done easily using `yargs` package. Also removed couple of unused dependencies.

[General] [changed] - used `yarns` package instead of `minimist` package

Pull Request resolved: #23467

Differential Revision: D14099638

Pulled By: cpojer

fbshipit-source-id: 59de2086e4204e09c91fd2c99d209ca32c0ef82c
  • Loading branch information
nimish-gupta authored and facebook-github-bot committed Feb 15, 2019
1 parent da5b5d2 commit 9f4ee25
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
2 changes: 1 addition & 1 deletion jest/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ global.cancelAnimationFrame = function(id) {
clearTimeout(id);
};

jest.mock('setupDevtools').mock('npmlog');
jest.mock('setupDevtools');

// there's a __mock__ for it.
jest.setMock('ErrorUtils', require('ErrorUtils'));
Expand Down
5 changes: 0 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -162,20 +162,15 @@
"@react-native-community/cli": "^1.1.0",
"art": "^0.10.0",
"base64-js": "^1.1.2",
"connect": "^3.6.5",
"create-react-class": "^15.6.3",
"debug": "^2.2.0",
"escape-string-regexp": "^1.0.5",
"event-target-shim": "^1.0.5",
"fbjs": "^1.0.0",
"fbjs-scripts": "^1.0.0",
"invariant": "^2.2.4",
"lodash": "^4.17.5",
"metro-babel-register": "0.51.0",
"metro-react-native-babel-transformer": "0.51.0",
"minimist": "^1.2.0",
"mkdirp": "^0.5.1",
"npmlog": "^2.0.4",
"nullthrows": "^1.1.0",
"pretty-format": "24.0.0-alpha.6",
"promise": "^7.1.1",
Expand Down
11 changes: 5 additions & 6 deletions scripts/bump-oss-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@
*/
const fs = require('fs');
const {cat, echo, exec, exit, sed} = require('shelljs');
const yargs = require('yargs');

const minimist = require('minimist');

let argv = minimist(process.argv.slice(2), {
alias: {remote: 'r'},
default: {remote: 'origin'},
});
let argv = yargs.option('r', {
alias: 'remote',
default: 'origin',
}).argv;

// - check we are in release branch, e.g. 0.33-stable
let branch = exec('git symbolic-ref --short HEAD', {
Expand Down

0 comments on commit 9f4ee25

Please sign in to comment.