Skip to content

Commit

Permalink
Delete unused method exposed in BaseJavaModule (#36907)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #36907

Delete unused method exposed in BaseJavaModule

bypass-github-export-checks

Changelog: [Android][Removed] Delete hasConstants() method from BaseJavaModule

Reviewed By: philIip

Differential Revision: D44678688

fbshipit-source-id: 9fd15f2097a6251fd2cf6c81c89370dd18c6bd6c
  • Loading branch information
mdvacca authored and facebook-github-bot committed Apr 20, 2023
1 parent 65bf785 commit bbc3657
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,12 @@ public void initialize() {

@Override
public boolean canOverrideExistingModule() {
// TODO(t11394819): Make this final and use annotation
return false;
}

@Override
public void onCatalystInstanceDestroy() {}

public boolean hasConstants() {
return false;
}

/**
* The CatalystInstance is going away with Venice. Therefore, the TurboModule infra introduces the
* invalidate() method to allow NativeModules to clean up after themselves.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@ protected void setupViewRecycling() {
* For the vast majority of ViewManagers, you will not need to override this. Only override this
* if you really know what you're doing and have a very unique use-case.
*
* @param viewToUpdate
* @param props
* @param viewToUpdate {@link T} View instance that will be updated with the props received by
* parameter.
* @param props {@link ReactStylesDiffMap} props to update the view with
*/
public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props) {
final ViewManagerDelegate<T> delegate = getDelegate();
Expand Down

0 comments on commit bbc3657

Please sign in to comment.