Skip to content

Commit

Permalink
Remove BatchedExecutionTime from Fabric metrics
Browse files Browse the repository at this point in the history
Summary: This diff removes BatchedExecutionTime from the metrics that are measured in Fabric. This does not add much value and it is not easy to compare against current version of RN

Reviewed By: shergin

Differential Revision: D14541976

fbshipit-source-id: c488e0951815306a978dd7a4246ec8a16d663218
  • Loading branch information
mdvacca authored and facebook-github-bot committed Mar 23, 2019
1 parent 8618a58 commit bd7df8b
Showing 1 changed file with 0 additions and 4 deletions.
Expand Up @@ -114,7 +114,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {

private long mRunStartTime = 0l;
private long mBatchedExecutionTime = 0l;
private long mNonBatchedExecutionTime = 0l;
private long mDispatchViewUpdatesTime = 0l;
private long mCommitStartTime = 0l;
private long mLayoutTime = 0l;
Expand Down Expand Up @@ -348,7 +347,6 @@ private void dispatchMountItems() {

@UiThread
private void dispatchPreMountItems(long frameTimeNanos) {
long nonBatchedExecutionStartTime = SystemClock.uptimeMillis();
Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManager::premountViews");

while (true) {
Expand All @@ -367,7 +365,6 @@ private void dispatchPreMountItems(long frameTimeNanos) {

preMountItemsToDispatch.execute(mMountingManager);
}
mNonBatchedExecutionTime = SystemClock.uptimeMillis() - nonBatchedExecutionStartTime;
Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE);
}

Expand Down Expand Up @@ -447,7 +444,6 @@ public Map<String, Long> getPerformanceCounters() {
performanceCounters.put("DispatchViewUpdatesTime", mDispatchViewUpdatesTime);
performanceCounters.put("RunStartTime", mRunStartTime);
performanceCounters.put("BatchedExecutionTime", mBatchedExecutionTime);
performanceCounters.put("NonBatchedExecutionTime", mNonBatchedExecutionTime);
performanceCounters.put("FinishFabricTransactionTime", mFinishTransactionTime);
performanceCounters.put("FinishFabricTransactionCPPTime", mFinishTransactionCPPTime);
return performanceCounters;
Expand Down

0 comments on commit bd7df8b

Please sign in to comment.