Permalink
Browse files

Android: Expose Image's onError event to JavaScript

Summary:
iOS supports an Image onError event. Android was firing the event but it was never reaching JavaScript because Android didn't include this event in `getExportedCustomDirectEventTypeConstants`.

**Test plan (required)**

Verified that the `onError` event now fires in a test app.

My team uses this change in our app.

Adam Comella
Microsoft Corp.
Closes #10902

Differential Revision: D4180149

Pulled By: ericvicenti

fbshipit-source-id: 4bf0b9aa7dc221d838d7b6b3e88bb47196dcadef
  • Loading branch information...
1 parent 191db90 commit e87e181998bf4f8efba2c7e04bec0929344600b9 @rigdern rigdern committed with Facebook Github Bot Nov 15, 2016
@@ -120,6 +120,10 @@ var Image = React.createClass({
*/
onLoadStart: PropTypes.func,
/**
+ * Invoked on load error
+ */
+ onError: PropTypes.func,
+ /**
* Invoked when load completes successfully
*/
onLoad: PropTypes.func,
@@ -284,10 +288,10 @@ var Image = React.createClass({
sources = source;
}
- const {onLoadStart, onLoad, onLoadEnd} = this.props;
+ const {onLoadStart, onLoad, onLoadEnd, onError} = this.props;
const nativeProps = merge(this.props, {
style,
- shouldNotifyLoadEvents: !!(onLoadStart || onLoad || onLoadEnd),
+ shouldNotifyLoadEvents: !!(onLoadStart || onLoad || onLoadEnd || onError),
src: sources,
loadingIndicatorSrc: loadingIndicatorSource ? loadingIndicatorSource.uri : null,
});
@@ -255,7 +255,6 @@ const Image = React.createClass({
onProgress: PropTypes.func,
/**
* Invoked on load error with `{nativeEvent: {error}}`.
- * @platform ios
*/
onError: PropTypes.func,
/**
@@ -178,6 +178,8 @@ public void setLoadHandlersRegistered(ReactImageView view, boolean shouldNotifyL
MapBuilder.of("registrationName", "onLoadStart"),
ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD),
MapBuilder.of("registrationName", "onLoad"),
+ ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_ERROR),
+ MapBuilder.of("registrationName", "onError"),
ImageLoadEvent.eventNameForType(ImageLoadEvent.ON_LOAD_END),
MapBuilder.of("registrationName", "onLoadEnd"));
}

0 comments on commit e87e181

Please sign in to comment.