update to match what's going on in latest commits

facebook · Nov 2, 2022 · f4d70e9 · f4d70e9
1 parent 34c9a3c
commit f4d70e9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/scripts/release-utils.js b/scripts/release-utils.js
@@ -98,21 +98,26 @@ function publishAndroidArtifactsToMaven(releaseVersion, isNightly) {
 
 function generateiOSArtifacts(
   jsiFolder,
-  hermesUtilsFolder,
+  hermesEngineFolder,
   hermesCoreSourceFolder,
   buildType,
   releaseVersion,
   targetFolder,
 ) {
   pushd(`${hermesCoreSourceFolder}`);
 
+  //Need to generate hermesc
+  exec(
+    `${hermesUtilsFolder}/utils/build-hermesc-xcode.sh ${hermesEngineFolder}/build_host_hermesc`,
+  );
+
   //Generating iOS Artifacts
   exec(
-    `JSI_PATH=${jsiFolder} BUILD_TYPE=${buildType} ${hermesUtilsFolder}/build-mac-framework.sh`,
+    `JSI_PATH=${jsiFolder} BUILD_TYPE=${buildType} ${hermesEngineFolder}/utils/build-mac-framework.sh`,
   );
 
   exec(
-    `JSI_PATH=${jsiFolder} BUILD_TYPE=${buildType} ${hermesUtilsFolder}/build-ios-framework.sh`,
+    `JSI_PATH=${jsiFolder} BUILD_TYPE=${buildType} ${hermesEngineFolder}/utils/build-ios-framework.sh`,
   );
 
   popd();
@@ -122,6 +127,7 @@ function generateiOSArtifacts(
     buildType,
     releaseVersion,
     targetFolder,
+    true, // this is excludeDebugSymbols, we keep it as the default
   );
 
   return tarballOutputPath;

diff --git a/scripts/test-e2e-local.js b/scripts/test-e2e-local.js
@@ -172,7 +172,7 @@ if (argv.target === 'RNTester') {
   // Setting up generating native iOS (will be done later)
   const repoRoot = pwd();
   const jsiFolder = `${repoRoot}/ReactCommon/jsi`;
-  const hermesUtilsFolder = `${repoRoot}/sdks/hermes-engine/utils`;
+  const hermesEngineFolder = `${repoRoot}/sdks/hermes-engine`;
   const hermesCoreSourceFolder = `${repoRoot}/sdks/hermes`;
 
   if (!fs.existsSync(hermesCoreSourceFolder)) {
@@ -191,7 +191,7 @@ if (argv.target === 'RNTester') {
   // Generate native files for iOS
   const tarballOutputPath = generateiOSArtifacts(
     jsiFolder,
-    hermesUtilsFolder,
+    hermesEngineFolder,
     hermesCoreSourceFolder,
     buildType,
     releaseVersion,