-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIs that are not available to extensions should be marked with NS_EXTENSION_UNAVAILABLE #10821
Comments
Thanks for filing the issue. This seems like something that should be fixed. Do you have a list of the particular APIs that need to be marked in this manner? Here's the summary from the linked issue, for context:
|
Closing this issue as we haven't heard back from the author. |
I have created multiple PRs for this purpose and one of them is pending.. Some got checked in and one of them is still pending. Let me go and see if I can find it. But I have been working around this by creating my own fork of react-native and pointing to it from my project |
Thanks for letting us know! I didn't see them here. Can you update your PRs to mention this issue? That way they'll automatically close this issue when they're merged. It also helps others see that a particular issue may already have a proposed fix in the pipeline. |
#14263 . Turns out this was closed due to some concern about wrapping APIs this fashion. It would be awesome if you could pursue an alternative way of fixing this issue so that I can upgrade to the facebook's react-native version, instead of using my forked version Thanks for follow up |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Description
We want to build an iMessage extension (available only in iOS 10+ and Xcode 8+) using React native. Cocoapods made some fixes in their 1.1.1 version that is causing React native pod integration to fail in iOS extensions. Here is the issue logged against Cocoapods.
In summary, Cocoapods made fixes to correctly check that the pods have marked "its APIs that don't work for extensions as NS_EXTENSION_UNAVAILABLE". This change has disabled us from using the React native pod in iOS extensions.
The errors are
Reproduction
I dont have sample project and can work on getting one if necessary
Additional Information
The text was updated successfully, but these errors were encountered: